Fix optimized log_softmax along non-contiguous dim #8595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#8382 certainly didn't fix this problem (and added it on x86), but I don't think it was correct on ARM prior to that either. Added a regression test. Differential Revision: [D69928884](https://our.internmc.facebook.com/intern/diff/D69928884/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8595
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 41b7592 with merge base 745be4e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
swolchok
pushed a commit
that referenced
this pull request
Feb 20, 2025
#8382 certainly didn't fix this problem (and added it on x86), but I don't think it was correct on ARM prior to that either. Added a regression test. Differential Revision: [D69928884](https://our.internmc.facebook.com/intern/diff/D69928884/) ghstack-source-id: 267433500 Pull Request resolved: #8595
|
This pull request was exported from Phabricator. Differential Revision: D69928884 |
This was referenced Feb 20, 2025
swolchok
added
the
release notes: ops & kernels
swolchok
changed the title
#8382 certainly didn't fix this problem (and added it on x86), but I don't think it was correct on ARM prior to that either. Added a regression test. Differential Revision: [D69928884](https://our.internmc.facebook.com/intern/diff/D69928884/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D69928884 |
mergennachin
approved these changes
Feb 24, 2025
#8382 certainly didn't fix this problem (and added it on x86), but I don't think it was correct on ARM prior to that either. Added a regression test. Differential Revision: [D69928884](https://our.internmc.facebook.com/intern/diff/D69928884/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D69928884 |
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
swolchok
added a commit
that referenced
this pull request
Feb 25, 2025
Fix log_softmax along non-contiguous dim Pull Request resolved: #8595 #8382 certainly didn't fix this problem (and added it on x86), but I don't think it was correct on ARM prior to that either. Added a regression test. ghstack-source-id: 268149462 @exported-using-ghexport Differential Revision: [D69928884](https://our.internmc.facebook.com/intern/diff/D69928884/) Co-authored-by: Scott Wolchok <[email protected]>
swolchok
added a commit
that referenced
this pull request
Feb 25, 2025
* Fix log_softmax along non-contiguous dim Pull Request resolved: #8595 #8382 certainly didn't fix this problem (and added it on x86), but I don't think it was correct on ARM prior to that either. Added a regression test. ghstack-source-id: 268149462 @exported-using-ghexport Differential Revision: [D69928884](https://our.internmc.facebook.com/intern/diff/D69928884/) * Re-enable optimized gelu test in CMake Pull Request resolved: #8597 I missed this line disabling the test. (Splitting out re-enable of log_softmax because I think that one needs fixes.) ghstack-source-id: 268149463 @exported-using-ghexport Differential Revision: [D69929122](https://our.internmc.facebook.com/intern/diff/D69929122/) --------- Co-authored-by: Scott Wolchok <[email protected]>
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
Pull Request resolved: pytorch/executorch#8595 #8382 certainly didn't fix this problem (and added it on x86), but I don't think it was correct on ARM prior to that either. Added a regression test. ghstack-source-id: 267443262 @exported-using-ghexport Differential Revision: [D69928884](https://our.internmc.facebook.com/intern/diff/D69928884/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
#8382 certainly didn't fix this problem (and added it on x86), but I don't think it was correct on ARM prior to that either.
Added a regression test.
Differential Revision: D69928884